ENH: Disable unnecessary compression support in LLVM build configuration #80
Conversation
…configuration The value of 10.11 was hard-coded for the external project build, but was not exposed at the SuperBuild level. This change makes the setting of the OSX_DEPLOYMENT_TARGET more transparent.
CMake building of llvm autodetects zstd and zlib from homebrew and automatically links against them. A compiler warning is given: ``` ld: warning: building for macOS-11.0, but linking with dylib '/opt/homebrew/opt/zstd/lib/libzstd.1.dylib' which was built for newer version 15.0 ``` Additionally, this prevents castxml from running on many systems due to the dependence on homebrew being installed with the same or newer version as was present during compilation.
otool -L ./clang-prefix/src/clang-build/lib/libclang-cpp.dylib
./clang-prefix/src/clang-build/lib/libclang-cpp.dylib:
@rpath/libclang-cpp.dylib (compatibility version 0.0.0, current version 0.0.0)
/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1226.0.0)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1356.0.0)
\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/
/opt/homebrew/opt/zstd/lib/libzstd.1.dylib (compatibility version 1.0.0, current version 1.5.7)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #undesirable dependency was automatically added.
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.12)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ #This is probably OK, but also not needed, so remove.
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 2000.67.0)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 4201.0.0) |
|
@thewtex This addresses an issue that was described with castxml on macs as being linked to homebrew zstd and zlib. This PR removes the unnecessary dependencies by disabling both ZSTD and ZLIB support. |
|
|
||
|
|
||
| if(APPLE) | ||
| set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "Set the minimum supported OSX target" FORCE) |
There was a problem hiding this comment.
I don't think we want FORCE here
There was a problem hiding this comment.
Without the force, the CMakeCache.txt file on disk has a value that is different from what is requested here. I think that the compilation uses the local variable setting, but it was really confusing to see a different value in the CMakeCache.txt.
Is there a way to ensure that no value is set in the CMakeCache.txt?
| endif() | ||
| # 2025-12-11 master | ||
| set(CastXML_GIT_TAG bca6af13daf298f6d63bf2e4d4488c11c7e99b22 CACHE STRING "CastXML Git revision.") | ||
| set(CastXML_GIT_TAG "216-Followup-MSVC-fix" CACHE STRING "CastXML Git revision." FORCE) |
There was a problem hiding this comment.
I don't think we want FORCE here
There was a problem hiding this comment.
In the absence of force, subsequent local changes did not take effect. This caused considerable confusion because I changed the value, but the clone retained the value recorded in the CACHE.
No force would be necessary on a clean, fresh build, but subsequent dirty builds seem to require the FORCE.
3 participants
CMake building of llvm autodetects zstd and zlib from homebrew and automatically links against them.